Refocus editor after toggling markup when no selection. fixes #369 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that we refocus the editor element after `toggleMarkup`. Clicking a button can cause the button to become focused (e.g. `document.activeElement === buttonElement`) but the window's `getSelection` is still in the editor. When the selection is in the editor but it is not focused, key up/down/press events don't fire on it. Since it has the selection, typing causes the browser to mutate the editor element's dom and bypass the key* event handlers. In addition to being generally unwanted, this has the downside that the mutation will insert text to match its surrounding style, so the `toggleMarkup` ends up having no effect. After this change, it is possible to click e.g. the "bold" button when the selection is collapsed, and the next characters typed will be bold, as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that we refocus the editor element after
toggleMarkup.Clicking a button can cause the button to become focused (e.g.
document.activeElement === buttonElement) but the window'sgetSelectionis still in the editor.When the selection is in the editor but it is not focused, key
up/down/press events don't fire on it. Since it has the selection,
typing causes the browser to mutate the editor element's dom and bypass
the key* event handlers. In addition to being generally unwanted, this has the
downside that the mutation will insert text to match its surrounding
style, so the
toggleMarkupends up having no effect.After this change, it is possible to click e.g. the "bold" button when
the selection is collapsed, and the next characters typed will be bold,
as expected.